deptofdefense / AndroidTacticalAssaultKit-CIV

Other
32 stars 14 forks source link

Shapes sent via GC are missing a device UID #244

Open FarrantAlex opened 2 years ago

FarrantAlex commented 2 years ago

CoT messages sent through GeoChat should contain the sender's UID for attribution. The circle, polyline, polygon and telestration only contain a UUID for the shape but not a device UID for attribution. As a result, these event types could be abused deliberately or accidentally to congest a network which would evade client dashboard monitoring which uses a device UID to generate client metrics.

To test this:

  1. Create a circle or polygon using the drawing tools
  2. Send the shape to another user on Geochat - or broadcast it
  3. Observe the circle has a UUID but is anonymous

Please can you add a device UID to shape messages so we don't have anonymous XML messages.