deptofdefense / anet

Advisor Network
MIT License
24 stars 16 forks source link

Rollup graph date handling is confusing #738

Closed NickHeiner closed 7 years ago

NickHeiner commented 7 years ago

rollup does not show reports

There are a few things going on here.

  1. Create reports for the current day
  2. Go to /rollup Expected: you see those reports Actual: you do not see any reports.
  3. Click on the date dropdown Expected: the current day is highlighted Actual: the next day is highlighted image
  4. Click on the next day ("28", in this case) Expected: No reports show up, because that's in the future Actual: The reports from today show up.

It looks like this is caused by the following:

    get rollupStart() { return moment(this.state.date).subtract(1, 'days').startOf('day').hour(19) } //7pm yesterday
    get rollupEnd() { return moment(this.state.date).endOf('day').hour(18) } // 6:59:59pm today.

I'm guessing this was done for a good reason, but I feel like the behavior I've documented here is confusing. Up to you what to do about it, obviously. :smile:

hunterp commented 7 years ago

this will shock you, but this is the intended behavior for reports released after 7pm. We pleaded with them to let us change this, but this is just the way it is for now.

closing wontfix.