Closed jgarber623-gov closed 6 years ago
@jgarber623-gov Did you test on IE11 and Edge?
@jgarber623-gov I'll rephrase my question - would it be helpful if someone with a working Windows VM running IE 11 were to test this PR?
would it be helpful if someone with a working Windows VM running IE 11 were to test this PR?
@jamesatheyDDS That would be most helpful! 😄
IE11:
MSEdge:
Checklist
I have…
bin/rails server
) and verified that my changes behave as expected.bin/rubocop
) and vulnerability scan (bin/brakeman
) against my changes.bin/rake spec
) and verified that all tests pass.Summary of Changes
This pull request adds a user-facing Feedback Form (available at
/feedback
). The implementation uses Rails' Action Mailer and a single view to generate a plaintext email including the user's feedback.Testing
To verify the changes proposed in this pull request…
git checkout add-feedback-form
,CONTRIBUTING.md
,brew services run mailhog
(if it's not already running),bin/rails server
,Screenshots
Initial Screen
![narrow](https://user-images.githubusercontent.com/27780860/36733557-fad4e736-1b9e-11e8-9d2d-7d461e6ab163.png) ![wide](https://user-images.githubusercontent.com/27780860/36733562-fda67a10-1b9e-11e8-96c6-6b51c7f41020.png)Thank You Screen
![thanks-narrow](https://user-images.githubusercontent.com/27780860/36733568-00cde1ec-1b9f-11e8-89a8-7d780c5bc294.png) ![thanks-wide](https://user-images.githubusercontent.com/27780860/36733571-0393f33a-1b9f-11e8-82ad-ce60477b6ca0.png)