deptofdefense / move.mil

The entry point website to the Defense Personal Property System (DPS).
https://www.move.mil
Other
15 stars 15 forks source link

Add Feedback Form #365

Closed jgarber623-gov closed 6 years ago

jgarber623-gov commented 6 years ago

Checklist

I have…

Summary of Changes

This pull request adds a user-facing Feedback Form (available at /feedback). The implementation uses Rails' Action Mailer and a single view to generate a plaintext email including the user's feedback.

Testing

To verify the changes proposed in this pull request…

  1. clone this repo,
  2. git checkout add-feedback-form,
  3. set up development dependencies according to CONTRIBUTING.md,
  4. run brew services run mailhog (if it's not already running),
  5. run bin/rails server,
  6. load up http://localhost:3000/feedback, fill out and submit the form, and
  7. load up http://localhost:8025 and observe a received email!

Screenshots

Initial Screen ![narrow](https://user-images.githubusercontent.com/27780860/36733557-fad4e736-1b9e-11e8-9d2d-7d461e6ab163.png) ![wide](https://user-images.githubusercontent.com/27780860/36733562-fda67a10-1b9e-11e8-96c6-6b51c7f41020.png)
Thank You Screen ![thanks-narrow](https://user-images.githubusercontent.com/27780860/36733568-00cde1ec-1b9f-11e8-89a8-7d780c5bc294.png) ![thanks-wide](https://user-images.githubusercontent.com/27780860/36733571-0393f33a-1b9f-11e8-82ad-ce60477b6ca0.png)
jamesatheyDDS commented 6 years ago

@jgarber623-gov Did you test on IE11 and Edge?

jamesatheyDDS commented 6 years ago

@jgarber623-gov I'll rephrase my question - would it be helpful if someone with a working Windows VM running IE 11 were to test this PR?

jgarber623-gov commented 6 years ago

would it be helpful if someone with a working Windows VM running IE 11 were to test this PR?

@jamesatheyDDS That would be most helpful! 😄

jamesatheyDDS commented 6 years ago

IE11:

virtualbox_msedge - win10_14_03_2018_12_20_31

MSEdge:

virtualbox_msedge - win10_14_03_2018_12_19_13