deptofdefense / move.mil

The entry point website to the Defense Personal Property System (DPS).
https://www.move.mil
Other
15 stars 15 forks source link

Add secret key generate to travis ci build to support forks #372

Open rich-allen-gov opened 6 years ago

rich-allen-gov commented 6 years ago

Checklist

I have…

Summary of Changes

If you want to work with a fork of the project, the build fails for pull requests, most likely due to this limitation. https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions and not having the SECRET_KEY_BASE environment variable set up. This is a small change to the travis build which just generates a secret key base at build time.

Testing

  1. In travis ci delete the SECRET_KEY_BASE variable.
  2. Run the build. You should not receive errors related to not having that variable set.

Link with behavior:

before: https://travis-ci.org/deptofdefense/move.mil/builds/352455122

after: This pull request should pass testing with no secret key base env var needed in configuration.