[x] run the application locally (bin/rails server) and verified that my changes behave as expected.
[x] run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
[x] run the test suite (bin/rake spec) and verified that all tests pass.
[x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
[x] thoroughly outlined below the steps necessary to test my changes.
[x] read, understand, and agree to the terms described in CONTRIBUTING.md.
Summary of Changes
This is a very small change to entitlements data. The rank names in the entitlements are used in places where an individual user is asked for their rank - the entitlements page and the PPM estimator page. Therefore, the rank name should be singular, not plural. ("Civilian Employee" was already singular.)
Testing
To verify the changes proposed in this pull request…
clone this repo,
git checkout rank-singular,
set up development dependencies according to CONTRIBUTING.md,
aileendds
commented
6 years ago
Checklist
I have…
bin/rails server) and verified that my changes behave as expected.bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.bin/rake spec) and verified that all tests pass.Summary of Changes
This is a very small change to entitlements data. The rank names in the entitlements are used in places where an individual user is asked for their rank - the entitlements page and the PPM estimator page. Therefore, the rank name should be singular, not plural. ("Civilian Employee" was already singular.)
Testing
To verify the changes proposed in this pull request…
rank-singular,bin/rails db:setup,bin/rails server, and