Closed jamesatheyDDS closed 6 years ago
Hi James... looks good! I'm not sure how to mark as good in gitHub
On Fri, Mar 23, 2018 at 10:13 AM, James Athey notifications@github.com wrote:
@jamesatheyDDS https://github.com/jamesatheydds requested your review on: deptofdefense/move.mil#397 https://github.com/deptofdefense/move.mil/pull/397 What To Expect: Loading / Moving Day - clear up confusion about signing in the remarks section.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/deptofdefense/move.mil/pull/397#event-1538225740, or mute the thread https://github.com/notifications/unsubscribe-auth/AVQkOM__-OG1lj-zf732CWc8X1S_ISDzks5thR9CgaJpZM4S4_mo .
Addresses #390.
Checklist
I have…
bin/rails server
) and verified that my changes behave as expected.bin/rubocop
) and vulnerability scan (bin/brakeman
) against my changes.bin/rake spec
) and verified that all tests pass.Summary of Changes
This pull request rearranges the words at the end of the "Loading / Moving Day" section in "What To Expect" for CONUS moves. It no longer implies signing in the remarks section.
Testing
To verify the changes proposed in this pull request…
wte_remarks_signing
,bin/rails server
, andScreenshots
Before:
After: