deptofdefense / move.mil

The entry point website to the Defense Personal Property System (DPS).
https://www.move.mil
Other
15 stars 15 forks source link

What To Expect: Loading / Moving Day - clear up confusion about signing in the remarks section #397

Closed jamesatheyDDS closed 6 years ago

jamesatheyDDS commented 6 years ago

Addresses #390.

Checklist

I have…

Summary of Changes

This pull request rearranges the words at the end of the "Loading / Moving Day" section in "What To Expect" for CONUS moves. It no longer implies signing in the remarks section.

Testing

To verify the changes proposed in this pull request…

  1. clone this repo,
  2. git checkout wte_remarks_signing,
  3. set up development dependencies according to CONTRIBUTING.md,
  4. run bin/rails server, and
  5. load up http://localhost:3000 in the Web browser of your choice.

Screenshots

Before:

screen shot 2018-03-23 at 12 07 05 pm

After:

screen shot 2018-03-23 at 12 06 45 pm
lfantano commented 6 years ago

Hi James... looks good! I'm not sure how to mark as good in gitHub

On Fri, Mar 23, 2018 at 10:13 AM, James Athey notifications@github.com wrote:

@jamesatheyDDS https://github.com/jamesatheydds requested your review on: deptofdefense/move.mil#397 https://github.com/deptofdefense/move.mil/pull/397 What To Expect: Loading / Moving Day - clear up confusion about signing in the remarks section.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/deptofdefense/move.mil/pull/397#event-1538225740, or mute the thread https://github.com/notifications/unsubscribe-auth/AVQkOM__-OG1lj-zf732CWc8X1S_ISDzks5thR9CgaJpZM4S4_mo .