[x] run the application locally (bin/rails server) and verified that my changes behave as expected.
[x] run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
[x] run the test suite (bin/rake spec) and verified that all tests pass.
[x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
[x] thoroughly outlined below the steps necessary to test my changes.
[x] attached screenshots illustrating relevant behavior before and after my changes.
[x] read, understand, and agree to the terms described in CONTRIBUTING.md.
Summary of Changes
This pull request adds banners and logos for the Marine Corps and Coast Guard to their respective service-specific information pages, and adds a logo for the Navy's page.
Testing
To verify the changes proposed in this pull request…
clone this repo,
git checkout remaining-service-banners,
set up development dependencies according to CONTRIBUTING.md,
Addresses #371.
Checklist
I have…
bin/rails server
) and verified that my changes behave as expected.bin/rubocop
) and vulnerability scan (bin/brakeman
) against my changes.bin/rake spec
) and verified that all tests pass.Summary of Changes
This pull request adds banners and logos for the Marine Corps and Coast Guard to their respective service-specific information pages, and adds a logo for the Navy's page.
Testing
To verify the changes proposed in this pull request…
remaining-service-banners
,bin/rails server
, andScreenshots
Marine Corps - Desktop Chrome
Marine Corps - iOS Safari
![img_b8a7f56262ad-1](https://user-images.githubusercontent.com/26554826/38503708-c0315f12-3be0-11e8-97b7-7ff17ed0db36.jpeg)Marine Corps - Desktop IE11
![virtualbox_msedge - win10_09_04_2018_10_28_59](https://user-images.githubusercontent.com/26554826/38503776-eba83a80-3be0-11e8-9bba-e5cd02221b1d.png)Navy - Desktop Chrome
Coast Guard - Desktop Chrome