Open jgarber623-gov opened 6 years ago
@jgarber623-gov I can haz screenshots?
Has the layout been smoke-tested on mobile Safari or mobile Chrome? Has the layout been smoke-tested on IE11?
Pro-tip: If there are any Windows machines on the same LAN as your dev machine, you can connect to your dev machine's port 3000 from them. Where you are working remotely, are there any Windows boxes?
Here is some feedback from Feld. The numbers correspond to James's comments above.
up -- "You can make a special trip to house hunt when you PCS, and you don't even have to use leave.. Same contraction rule -- use "you're" instead of "you are"
Overall: Active, power voice. We should look into removing instances of "can" whenever possible. "If necessary, you can get a <%= abbr_tag('tla') %> advance payment" => "If you need it, get a TLA advance payment..." "In addition to lodging and meals, you can also get reimbursed for currency conversion fees." => "Submit reimbursement for lodging, meals, and
Checklist
I have…
bin/rails server
) and verified that my changes behave as expected.bin/rubocop
) and vulnerability scan (bin/brakeman
) against my changes.bin/rake spec
) and verified that all tests pass.Summary of Changes
This pull request adds content to the Reimbursements page and creates a new Reimbursements for Civilians page. It resolves #136.
Testing
To verify the changes proposed in this pull request…
git checkout add-reimbursements-page
,CONTRIBUTING.md
,bin/rails server
,