Add Reimbursements Pages

[jgarber623-gov]

Checklist

I have…

• [x] run the application locally (bin/rails server) and verified that my changes behave as expected.
• [x] run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
• [x] run the test suite (bin/rake spec) and verified that all tests pass.
• [x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
• [x] thoroughly outlined below the steps necessary to test my changes.

Summary of Changes

This pull request adds content to the Reimbursements page and creates a new Reimbursements for Civilians page. It resolves #136.

Testing

To verify the changes proposed in this pull request…

1. clone this repo,
2. git checkout add-reimbursements-page,
3. set up development dependencies according to CONTRIBUTING.md,
4. run bin/rails server,
5. load up http://localhost:3000/moving-guidereimbursements
6. load up http://localhost:3000/moving-guide/reimbursements/reimbursements-for-civilians

[jamesatheyDDS]

@jgarber623-gov I can haz screenshots?

[jamesatheyDDS]

Has the layout been smoke-tested on mobile Safari or mobile Chrome? Has the layout been smoke-tested on IE11?

Pro-tip: If there are any Windows machines on the same LAN as your dev machine, you can connect to your dev machine's port 3000 from them. Where you are working remotely, are there any Windows boxes?

[pglevy]

Here is some feedback from Feld. The numbers correspond to James's comments above.

1. Good - Overall, no complaints. Overall, I think "reimburse" and "reimbursement" is a bit of a tough chew, but currently, it's good.
2. No Good - People generally don't get the hyphenated words -- "out of pocket" tends easier to read than "out-of-pocket."
3. No Good - would advise re-writing the second sentence. "In any move, you have to pay for some things (stuff?) up front. You can request a monetary advance to help cover your costs if you think you'll need help paying for the move."
4. Good - Lists are good, as long as they're capitalised correctly, I'm good with this one. the sentence under the UL is really, really tough to read - 4a. “When possible, use your government travel card during your PCS. You can find out more about the Government Travel Card… 4b. If you don't use your government travel credit card, you can get an advance of up to 80% of your per diem and mileage allowance. DLA equal to 100% of the anticipated entitlement. For DTY moves, your advance is calculated by your transportation office.”
5. Agreed -- confusing lines to someone with no experience on the move process. Also, "heads up," not "head's up."
6. Don't use "they are" -- use "they're" (same with "were not" vs "weren't" -- "they're experts who've helped thousands..."
7. Would clean the first

   up -- "You can make a special trip to house hunt when you PCS, and you don't even have to use leave.. Same contraction rule -- use "you're" instead of "you are"

8. Agreed -- this means nothing to people, from what I can glean. Use "car/truck" or clarify what PoC means here.
9. Agreed -- we're using "you" site-wide currently, and that's how it should be. Any instances of "member" or "service member" or "dependant traveler" should be reworded to "you," "your family," or "your dependants."
10. Agreed with James' suggested change -- clean wording, exciting tone, conversational.
11. Good -- would recommend removing the "for example" part to simplify.
12. No Good - would recommend changing "service member" to "people" -- "After reimbursement, most people ultimately pay nothing..."
13. Agreed -- wording is fine, just link the whole shebang!
14. Good? -- Still want to know what "can" means in this context.
15. Good -- agreed that this is most likely for pets.
16. Agreed -- if copy is shared, copy-edits should be shared too!

Overall: Active, power voice. We should look into removing instances of "can" whenever possible. "If necessary, you can get a <%= abbr_tag('tla') %> advance payment" => "If you need it, get a TLA advance payment..." "In addition to lodging and meals, you can also get reimbursed for currency conversion fees." => "Submit reimbursement for lodging, meals, and currency conversion fees." If it's something that's in there for legal purposes, it is what it is, but otherwise we should remove that word. It has a very strong connotation to readers, and may lead them to the "negative" outcome -- I "can" be reimbursed, but I probably won't be -- this sucks!