[x] run the application locally (bin/rails server) and verified that my changes behave as expected.
[x] run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
[x] run the test suite (bin/rake spec) and verified that all tests pass.
[x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
[x] thoroughly outlined below the steps necessary to test my changes.
[ ] attached screenshots illustrating relevant behavior before and after my changes.
[x] tested my changes in a modern desktop browser, Internet Explorer 11, and a modern mobile browser.
[x] read, understand, and agree to the terms described in CONTRIBUTING.md.
Summary of Changes
This pull request removes the branch of service input field from the PPM Estimator, as all services now offer up to a 60% advance. It also adjusts the formatting of the output slightly so that the "Your Details:" and rank strings fit on the same line more often.
Testing
To verify the changes proposed in this pull request…
clone this repo,
git checkout common-advance-60,
set up development dependencies according to CONTRIBUTING.md,
Addresses #415.
Checklist
I have…
bin/rails server) and verified that my changes behave as expected.bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.bin/rake spec) and verified that all tests pass.Summary of Changes
This pull request removes the branch of service input field from the PPM Estimator, as all services now offer up to a 60% advance. It also adjusts the formatting of the output slightly so that the "Your Details:" and rank strings fit on the same line more often.
Testing
To verify the changes proposed in this pull request…
common-advance-60,bin/rails server, andScreenshots