Add High Value Inventory Worksheet page content

jgarber623-gov commented 6 years ago

Checklist

I have…

[x] run the application locally (bin/rails server) and verified that my changes behave as expected.
[x] run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
[x] run the test suite (bin/rake spec) and verified that all tests pass.
[x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
[x] thoroughly outlined below the steps necessary to test my changes.
[x] attached screenshots illustrating relevant behavior before and after my changes.

Summary of Changes

This pull request adds content to the High Value Inventory Worksheet page, including a downloadable PDF version of the worksheet.

Testing

To verify the changes proposed in this pull request…

clone this repo,
git checkout add-high-value-inventory-worksheet,
set up development dependencies according to CONTRIBUTING.md,
run bin/rails server,
load up http://localhost:3000/resources/inventory-form

Screenshots

Narrow Viewport

![inventory-worksheet-narrow](https://user-images.githubusercontent.com/27780860/38944430-d97dece2-4301-11e8-8baf-dad19cb87ccd.png)

Wide Viewport

![inventory-worksheet-wide](https://user-images.githubusercontent.com/27780860/38944433-dd1d9352-4301-11e8-9d20-859047111fc4.png)

jamesatheyDDS commented 6 years ago

Do I understand the point of this page? That the user is supposed to download a PDF, print it out, and fill it in to track high-value inventory?

jgarber623-gov commented 6 years ago

@jamesatheyDDS Correct.

jamesatheyDDS commented 6 years ago

Ugh. Printing a PDF and filling it in by hand. We were doing so well in limiting the number of PDFs.

I guess this PDF won't need to exist some distant point in the future when my.move.mil has a digital inventory?

jamesatheyDDS commented 6 years ago

BTW you need to put a new line around the images in the <details> tags for it to work.

jgarber623-gov commented 6 years ago

Ugh. Printing a PDF and filling it in by hand. We were doing so well in limiting the number of PDFs.

I guess this PDF won't need to exist some distant point in the future when my.move.mil has a digital inventory?

@jamesatheyDDS I know @lfantano can provide some context but I believe the intention was always for this to be a printed document so this addition shouldn't represent a step in a negative direction.

jgarber623-gov commented 6 years ago

The requested design includes a PDF icon from the Font Awesome set. I don't know whether or not we have a license to use that set, so I've left it out of the build so far.

@lfantano Do we have a licensed version of this icon that we can use on move.mil?

large

deptofdefense / move.mil