Closed jgarber623-gov closed 6 years ago
Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.
I have…
bin/rails server
bin/rubocop
bin/brakeman
bin/rake spec
This pull request resolves several small UI bugs introduced by #417. See screenshots below for some examples.
min="0"
The changes here update numeric inputs on the Weight Estimator and on the PPM Estimator.
To verify the changes proposed in this pull request…
git checkout fix-numeric-input-ui-bugs
CONTRIBUTING.md
Hey, it's not a bug introduced by #417. You could type negative numbers in these fields before.
Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.
Checklist
I have…
bin/rails server
) and verified that my changes behave as expected.bin/rubocop
) and vulnerability scan (bin/brakeman
) against my changes.bin/rake spec
) and verified that all tests pass.Summary of Changes
This pull request resolves several small UI bugs introduced by #417. See screenshots below for some examples.
min="0"
which would (on the front-end anyway) allow users to spin the input below zero.The changes here update numeric inputs on the Weight Estimator and on the PPM Estimator.
Testing
To verify the changes proposed in this pull request…
git checkout fix-numeric-input-ui-bugs
,CONTRIBUTING.md
,bin/rails server
,Screenshots
Before
After