Fix numeric input UI bugs introduced in PR #417

[jgarber623-gov]

Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.

Checklist

I have…

• [x] run the application locally (bin/rails server) and verified that my changes behave as expected.
• [x] run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
• [x] run the test suite (bin/rake spec) and verified that all tests pass.
• [x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
• [x] thoroughly outlined below the steps necessary to test my changes.
• [x] attached screenshots illustrating relevant behavior before and after my changes.

Summary of Changes

This pull request resolves several small UI bugs introduced by #417. See screenshots below for some examples.

1. Numeric input fields in WebKit browsers displayed number spinners which (on the weight estimator) would overlay the user's input value.
2. Numeric input fields lacked a min="0" which would (on the front-end anyway) allow users to spin the input below zero.

The changes here update numeric inputs on the Weight Estimator and on the PPM Estimator.

Testing

To verify the changes proposed in this pull request…

1. clone this repo,
2. git checkout fix-numeric-input-ui-bugs,
3. set up development dependencies according to CONTRIBUTING.md,
4. run bin/rails server,
5. load up http://localhost:3000/resources/weight-estimator and note that spinners no longer appear in numeric fields.

Screenshots

Before

After

[jamesatheyDDS]

Hey, it's not a bug introduced by #417. You could type negative numbers in these fields before.