depub-team / depub.space

Monorepo for DePub Space projects
https://depub.space
10 stars 2 forks source link

Ricard de la/fix/chinese char url #115

Closed RicardDeLa closed 2 years ago

RicardDeLa commented 2 years ago

for issue #109

@0xtaipoian
I have commented maxLength on textarea, because I found the length limitation may break the decode message for example, when user paste this url , which is length is 397 before url decode

https://news.mingpao.com/ins/%e6%96%87%e6%91%98/article/20220601/s00022/1654006767044/%e5%85%ad%e6%9c%88%e5%ad%a4%e9%ad%82%e7%84%a1%e8%99%95%e8%a8%b4-%e5%9b%9b%e6%99%82%e8%8a%b1%e8%8d%89%e6%9c%89%e6%81%a8%e5%87%9d-%e2%94%80%e2%94%80%e5%af%ab%e5%9c%a8%e6%82%bc%e5%bf%b5%e3%80%8c%e5%85%ad%e5%9b%9b%e3%80%8d33%e5%91%a8%e5%b9%b4%e4%b9%8b%e9%9a%9b%ef%bc%88%e6%96%87-%e5%8a%89%e9%8a%b3%e7%b4%b9%ef%bc%89

then the message will be cut by first 280 chars, and the url decode will raise error

that's why I commented the maxLength, user will see the error msg when submit if message is longer than 280 char

see if you agree on this change

RicardDeLa commented 2 years ago

also fix #117