Closed GoogleCodeExporter closed 9 years ago
Great idea, although I'm not sure about using month/week/day. Would be a lot
easier to implement if we just allowed a timestring (7d 0h 30m, etc.). Then
you could just do a week with 7d, two weeks with 14d, and a month with 30d.
Original comment by widdis@gmail.com
on 4 Jul 2010 at 5:57
Yeah, I like this, too.
Original comment by Fleety...@gmail.com
on 16 Jul 2010 at 3:21
Implemented in r344.
Original comment by widdis@gmail.com
on 17 Aug 2010 at 10:29
I like this a lot, but made one teensy modification, and a fix to the
notification.
The modification was to add the time amount with the OPENED_ON attribute,
rather than the current time. I primarily use it for player requests that are
due a certain period of time from the time of the request. If some time has
gone by, before the due date is set, no one needs to figure out how much time
is left, or to misread a calendar.
The notification message generated is 'You have set Job Number ##'s date to
30d.' rather than the actual date that was set.
My changes:
Line 817:
1[setq(1,add(%q1,u(%q0/OPENED_ON)))],
Line 845:
@pemit %#=You have set Job Number %0's date to convsecs(%q1).;
(My apologies if this isn't the right/appropriate place to post this - point me
to the right place, and I'll be happy to do so.)
Original comment by Tyar...@gmail.com
on 21 Aug 2010 at 10:02
1. Setting due dates from the time of the request is most easily done with the
bucket TURNAROUND attribute, or with appropriate settings on HOOK_CRE or
HOOK_OTH. By the time someone is using the +job/due command, some time may
have passed. On my game, for example, I usually use +job/due when a job is
overdue (or almost so) and I've just taken some action (+job/mail-ing a player,
etc.) and want to give myself extra time, somewhat like a "snooze" button on an
alarm clock. So I think time-from-now is much preferable to
time-from-job-start.
Other opinions?
2. The notification (line 845) could use improvement. Your convsecs()
suggestion is good, or we might consider something with timefmt(). I'll toss
that into the next version. Reopening this issue as a reminder and for
discussion of the first point.
Original comment by widdis@gmail.com
on 22 Aug 2010 at 10:28
Updated in r361.
Original comment by widdis@gmail.com
on 4 Nov 2010 at 7:04
Original issue reported on code.google.com by
tala...@gmail.com
on 4 Jul 2010 at 12:04