depwl9992 / anomalyjobs

Automatically exported from code.google.com/p/anomalyjobs
0 stars 0 forks source link

Error in CMD_JGROUP/MEMBER #132

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a group.
2. Set group to MEMBERLIST
3. Add a new member to the memberlist.

What is the expected output?
Member should be added to memberlist.

What do you see instead?
'remove member' code is run instead.

What version of the product are you using? On what MU* Server?
6.1 with pennmush 184p1

Please provide any additional information below.
Suggest the following change:
Change '[u(%q1/MEMBER,%q0)]' to '[strmatch(u(%q1/MEMBERLIST),*%q0*)]'

My tests show that this fix works. I'm not a high level coder, but if it works, 
use it. Let me know if there is a better way to do this.

Original issue reported on code.google.com by blank.forrest on 15 Nov 2010 at 5:07

GoogleCodeExporter commented 9 years ago
I do not understand what was done in step 2, "Set group to MEMBERLIST".  I do 
not see [u(%q1/MEMBER,%q0)] anywhere in the jobs code.

I suspect that whatever was done in step 2 caused this issue, as well as Issue 
133.

Original comment by widdis@gmail.com on 15 Nov 2010 at 7:30

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
After rereading this, it looks like the recommended change meant to reference 
%q1/ISMEMBER.  Both this and Issue 133 appear to bypass the intended use of the 
ISMEMBER function and directly access MEMBERLIST.

However, this should be unnecessary if the ISMEMBER function is left at its 
default of t(member(v(MEMBERLIST),%0))

Based on the symptoms reported in this issue and Issue 133, I suspect OP 
changed ISMEMBER to some function which returns 1 for every player.

There may be need for additional documentation of jgroups and the use of 
ISMEMBER but I do not think there is a code issue.

Original comment by widdis@gmail.com on 15 Nov 2010 at 7:42

GoogleCodeExporter commented 9 years ago
Indeed you are correct, please close this bug as it is OP ERROR, and not 
programmer error.

Original comment by blank.forrest on 15 Nov 2010 at 10:39

GoogleCodeExporter commented 9 years ago

Original comment by widdis@gmail.com on 15 Nov 2010 at 10:45