depwl9992 / anomalyjobs

Automatically exported from code.google.com/p/anomalyjobs
0 stars 0 forks source link

Assigning/Tagging "me" #144

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. +job/assign or +job/tag a job to "me" (e.g. +job/assign 123=me)

What is the expected output?
The job is assigned to the player running the command.

What do you see instead?
The job is assigned to the job system owner.

Original issue reported on code.google.com by kkragenb...@gmail.com on 12 Feb 2011 at 5:29

GoogleCodeExporter commented 9 years ago
This is actually platform dependent, and as described only occurs on RhostMUSH.

On both MUX and Penn you get "There is no player or jgroup by that name."

The root of the problem is that the commands listed (and others, no doubt) use 
pmatch() to parse the argument, and pmatch() does not understand "me". 

I might argue that pmatch() ought to replace "me" with %# in commands, rather 
than with %!, but that's an argument to take up with a RhostMUSH dev. And 
apparently PennMUSH has chosen not to implement pmatch(me) for precisely this 
(confusing) reason.

In any case, I can either toss a check for "me" in the switch() and have it use 
%# rather than the pmatch.  Or replace the pmatch() with locate(%#,%1,PFmy). 
This fixes the (possibly correct technically but useless practically) RhostMUSH 
implementation and improves on the lack of "me" interpretation in Penn and MUX.

Original comment by widdis@gmail.com on 12 Feb 2011 at 8:41

GoogleCodeExporter commented 9 years ago
Done in r391.

Original comment by widdis@gmail.com on 12 Feb 2011 at 9:32