depwl9992 / anomalyjobs

Automatically exported from code.google.com/p/anomalyjobs
0 stars 0 forks source link

+job/publish does not unpublish comments properly. #159

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to unpublish any comments made by the job source.  You cannot.
2. If the job's source is multiple dbrefs, you can unpublish any comments.  
They still don't show up as unpublished to the user who submitted them.

What is the expected output?

When you unpublish a comment, I would expect you would see that these comments 
aren't published anymore (-).  That never happens. 

What do you see instead?

Comments are always published (+).  

What version of the product are you using? On what MU* Server?

6.4, PennMUSH 1.8.3.

Please provide any additional information below.

I suspect the only real need to fix here is in DEFAULT_READ (or whatever 
skin_READ).  Instead of switch(extract(get(... perhaps it should be some sort 
of match to appropriately check for multiple ID's in the SOURCE?

Original issue reported on code.google.com by clan...@gmail.com on 7 Jul 2011 at 8:39

GoogleCodeExporter commented 9 years ago
IIRC, this was a design decision. The creator of a comment is never barred from 
seeing their contribution, provided that job is accessible via myjobs. This 
lets the commenter know that their input did not get arbitrarily deleted. 
Publishing is for toggling potentially sensitive information within a job, and 
since the commenter knows everything he placed into the comment, it doesn't 
make sense that we should try and bar the comment's originator.

If you want the whole job hidden from view, it's best to transfer it to a 
bucket that is not accessible to myjobs.

Original comment by Fleety...@gmail.com on 12 Jul 2011 at 1:28