depwl9992 / anomalyjobs

Automatically exported from code.google.com/p/anomalyjobs
0 stars 0 forks source link

Skins should respect width() #84

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently the utility of setting one's &JOBS attribute is limited by screen
width; more columns can display on a wider screen but the headers end up short.

We should attempt to use width() to make the headers/footers/wrap stuff
wider if a player's client reports a wider width.

Note: This calls for a FN_WIDTH wrapper, of course, which can presume 78 if
the game does not have a width() function.

Penn's default width() is 78 and is changed per-player using commands.

MUX default width() is 80 and is (possibly) changed during telnet negotiation.

Original issue reported on code.google.com by widdis@gmail.com on 18 Jan 2010 at 9:45

GoogleCodeExporter commented 9 years ago
r238 implements &FN_FLEXWIDTH and applies it to all existing skins (fixing a few
other formatting issues).

However, I'm leaving this issue open because there's still a &JOBS vs. width 
issue.

I've honestly tried to use other settings for &JOBS than the default (such as 
TOADS),
but it's hard to get combinations that add up to the right width.  Obviously 
making a
wider screen will help with some of that, but while editing BUCKETLIST to make 
it
flexible, I thought we ought to be able to do the same thing with JOBLIST... 
widen or
shrink some of the columns (within bounds) in order to squeeze them in.

Obviously some columns (DSC#BMF) are fixed-width, but that leaves us room to 
fiddle
with the TAO fields.

Original comment by widdis@gmail.com on 18 Jan 2010 at 7:00

GoogleCodeExporter commented 9 years ago
Per discussion with Fleety219, will update FN_FLEXWIDTH to get width from a user
attribute in case their client doesn't properly report width.  

(This should be the last resort:  tf and MUSHclient are capable of changing 
reported
width() on the fly, and setting an attribute will override system changes.)

Original comment by widdis@gmail.com on 18 Jan 2010 at 7:37

GoogleCodeExporter commented 9 years ago
r240 implements JOBSWIDTH (override for width()) and JOBSWIDTH_<field> 
attributes
which make the various &JOBS columns arbitrary widths.  

I now have &JOBS me=BCTOAD within 80 characters by reducing JOBSWIDTH_A and _O 
to 11
and _T to 23. :)

I've tested quite a bit (with tf and MUSHclient on Penn and MUX with all four 
skins
and various screen combinations) but this could use another set of eyes.

Original comment by widdis@gmail.com on 18 Jan 2010 at 11:23

GoogleCodeExporter commented 9 years ago
I've pounded on it (okay, I've indelicately whacked it a couple of times) and 
it looks good to me.

Original comment by Fleety...@gmail.com on 21 Jan 2010 at 2:43

GoogleCodeExporter commented 9 years ago

Original comment by widdis@gmail.com on 21 Jan 2010 at 7:02