search

depyronick / nestjs-clickhouse

ClickHouse Client Module for Nest Framework (node.js)
https://clickhouse.js.org
MIT License
43 stars 6 forks source link

useFactory #12

Closed ilyamixaltik closed 1 year ago

ilyamixaltik commented 1 year ago

Is there an existing issue for this?

Current behavior

Problems with types useFactory. All keys are optional in the config except the "httpConfig" key. This key is mandatory, but there is no information about where to get the data that needs to be placed there. There is also no information in the documentation. And the example from the documentation causes an error.

Minimum reproduction code

https://github.com/

Steps to reproduce

No response

Expected behavior

Need to find out where to get the data for httpConfig

Package version

2.0.0

NestJS version

No response

Node.js version

No response

In which operating systems have you tested?

Other

No response

depyronick commented 1 year ago

related to: https://github.com/depyronick/clickhouse-client/blob/d61d1022878f28b07cafbe447a2cd91440e75919/src/client/interfaces/ClickHouseClientOptions.ts#L150

depyronick commented 1 year ago

httpConfig should not be mandatory and should be assigned defaults on construction. will work on a fix asap thanks for reporting

ilyamixaltik commented 1 year ago

Are there any advancements?

depyronick commented 1 year ago

Are there any advancements?

hopefully today

depyronick commented 1 year ago

@ilyamixaltik sorry, having a busy week, its on my mind

ilyamixaltik commented 1 year ago

@depyronick Nothing, I understand everything. At the moment I'm trying an older version. I hope by the time of active development you will be able to fix library