search

depyronick / nestjs-clickhouse

ClickHouse Client Module for Nest Framework (node.js)
https://clickhouse.js.org
MIT License
46 stars 6 forks source link

Inject multiple registerAsync clickhouse clients #19

Closed stouch closed 2 weeks ago

stouch commented 1 month ago

Is there an existing issue that is already proposing this?

Is your feature request related to a problem? Please describe it

It was not possible to connect multiple DI clients with async configuration.

Describe the solution you'd like

I made a PR to solve this : https://github.com/depyronick/nestjs-clickhouse/pull/18

Teachability, documentation, adoption, migration strategy

You then just have to set a name in the registerAsync to get the injected client.

What is the motivation / use case for changing the behavior?

Multiple DI clickhouse clients.

stouch commented 1 month ago

@depyronick Do you know if you plan to keep this feature ? For now I have to use my fork to be able to inject 2 registerAsync clients.

depyronick commented 1 month ago

@depyronick Do you know if you plan to keep this feature ? For now I have to use my fork to be able to inject 2 registerAsync clients.

hi. thanks for the contribution. i'll merge and release the new version asap.

stouch commented 3 weeks ago

Any news about this one ?

depyronick commented 2 weeks ago

@stouch https://github.com/depyronick/nestjs-clickhouse/releases/tag/2.0.5