search

dequbed / rsasl

The Rust SASL framework
MIT License
12 stars 6 forks source link

Replace `acid_io` by `core2` #40

Closed Mathieu-Lala closed 3 months ago

Mathieu-Lala commented 6 months ago

Hello :wave:

This advisory has been bothering me since a while. The origin of it is acid_io, where the issue has been fixed, but no release has been publish :disappointed: (since 3 years!)

So, after reading this discussion/issue, I decided to replace acid_io for core2 (which seems quite used, even if the last release was 2 years ago).

The changes was trivial as acid_io and core2::io have the same API as std::io. But, while trying to test those changes, the CI failed (which was also the case last week). So I started to fix the CI, and made changes to make the CI pass.

I also added a dependabot.yaml, PR will be created monthly to update the dependencies in the Cargo.toml and ci.yml.

I formatted the README.md and Cargo.toml.

I had to bump MSRV to 1.65.

I bumped the dependencies to their latest versions, and pushed the Cargo.lock, see why.

And I ran cargo clippy --fix and cargo fmt, with not much modification from myself.

I just finished to write the description of this PR and realize that someone was working on https://github.com/dequbed/rsasl/pull/36, oops

duesee commented 6 months ago

I just finished to write the description of this PR and realize that someone was working on https://github.com/dequbed/rsasl/pull/36, oops

Don't worry! As far as I remember, I wasn"t sure how to proceed with the PR. If you know how, please feel free to take anything you need from it (or not :-)). Can also be closed should it be/get outdated. Not much time to work on it currently :-(

Mathieu-Lala commented 6 months ago

close https://github.com/dequbed/rsasl/issues/37

Mathieu-Lala commented 6 months ago

I managed to make all the CI job pass, i also added a docs and spellcheck jobs.

Feel free to edit/push on this branch if you are not satisfied with some changes

dequbed commented 3 months ago

Thanks @Mathieu-Lala for this PR! I'm not perfectly clear if the lifetimes chances are correct (in the correctness despite unsafe meaning), but given they (seem to) fix #41 I'm going to merge this first and add some tests later making sure they also keep API for semver. :)