breaking: Converts AxeImpact to enum - Githubissues

dequelabs / axe-android

WCAG Accessibility compliance library for Android Applications.

Mozilla Public License 2.0

65 stars 19 forks source link

breaking: Converts AxeImpact to enum #120

Closed devchan4188 closed 4 years ago

devchan4188 commented 4 years ago

This was supposed to be breaking change: https://github.com/dequelabs/axe-android/pull/97

This PR fixes our semantic versioning and nothing else.

Requester Review Items

[x] Ensure the Pull Request is into develop.
[x] Test coverage has not gone down.
[x] Documentation updated or not needed. (Wiki, Issues, etc)
[x] Angular Type leads to proper Semantic Version.

Dev Team Review Items

To be filled out by @dequelabs/mobile.

[x] Ensure the Requester did not lie. Chastise them politely if they did.
[x] Code Quality review.
[x] Changes to Axe*.java classes are minimal, appropriate, and versioned properly.
- [x] Serialized Axe objects have not changed.
- [x] Public API has not changed.

Code Owner Review Items

To be filled out by @dequelabs/mobileadmin.

[x] Any Rules package changes lead to proper Semantic Version.
[x] Security Review.

Merger Review Items

[ ] Ensure commit message matches title before squashing.