feat: Add WebView detection to AxeView - Githubissues

dequelabs / axe-android

WCAG Accessibility compliance library for Android Applications.

Mozilla Public License 2.0

65 stars 19 forks source link

feat: Add WebView detection to AxeView #40

Closed cyono closed 5 years ago

cyono commented 5 years ago

Closes: #37

See https://github.com/dequelabs/axe-android-app/pull/53 for an implementation.

Requester Review Items

[x] Ensure the Pull Request is into develop.
[x] Test coverage has not gone down.
[ ] Documentation updated or not needed. (Wiki, Issues, etc)
[x] Angular Type leads to proper Semantic Version.

Dev Team Review Items

To be filled out by @dequelabs/mobile.

[ ] Ensure the Requester did not lie. Chastise them politely if they did.
[ ] Code Quality review.
[ ] Changes to Axe*.java classes are minimal, appropriate, and versioned properly.
- [ ] Serialized Axe objects have not changed.
- [ ] Public API has not changed.

Code Owner Review Items

To be filled out by @dequelabs/mobileadmin.

[ ] Any Rules package changes lead to proper Semantic Version.
[ ] Security Review.

Merger Review Items

[ ] Ensure commit message matches title before squashing.

cyono commented 5 years ago

Further refactoring of computed properties required. A larger PR will contain this same work and an updated Readme.