fix: Stop making build successful if tests fail - Githubissues

dequelabs / axe-android

WCAG Accessibility compliance library for Android Applications.

Mozilla Public License 2.0

65 stars 19 forks source link

fix: Stop making build successful if tests fail #87

Closed devchan4188 closed 4 years ago

devchan4188 commented 4 years ago

Closes: dequelabs/axe-android-app#125

Requester Review Items

[x] Ensure the Pull Request is into develop.
[x] Test coverage has not gone down.
[x] Documentation updated or not needed. (Wiki, Issues, etc)
[x] Angular Type leads to proper Semantic Version.

Dev Team Review Items

To be filled out by @dequelabs/mobile.

[x] Ensure the Requester did not lie. Chastise them politely if they did.
[x] Code Quality review.
[x] Changes to Axe*.java classes are minimal, appropriate, and versioned properly.
- [x] Serialized Axe objects have not changed.
- [x] Public API has not changed.

Code Owner Review Items

To be filled out by @dequelabs/mobileadmin.

[ ] Any Rules package changes lead to proper Semantic Version.
[ ] Security Review.

Merger Review Items

[ ] Ensure commit message matches title before squashing.

cyono commented 4 years ago

This PR began codeowner file work, closing this so we can open a more accurate and relevant PR.

devchan4188 commented 4 years ago

This PR began codeowner file work, closing this so we can open a more accurate and relevant PR.

@cyono I have removed the CODEOWNER file changes from this PR, will create a separate PR for the CODEOWNER changes.