search

dequelabs / axe-cli

[Deprecated] A command-line interface for the aXe accessibility testing engine
Mozilla Public License 2.0
430 stars 44 forks source link

Contrast-check returns false positives #12

Closed boyum closed 7 years ago

boyum commented 7 years ago

I haven't really looked into the maths at this one, but I suspect that this isn't correct.

I get this error: image

On this part of the page (specifically the dates): image

Having these color values (contrast ratio: 12.7:1): image

It would be nice if the cli returned the values it calculated. In this case, it might be triggered by the font-size, which is 16px.

dylanb commented 7 years ago

Can you open an issue for this on the axe-core project please https://github.com/dequelabs/axe-core

marcysutton commented 7 years ago

If you can reproduce it with axe-core, that is. If it's limited to axe-cli, we'll want to document it here. I mention that because I've seen differences in what gets returned by axe-cli depending on the driver (ex. PhantomJS or Chrome).

boyum commented 7 years ago

The aXe Chrome extension does not find any violations on the same page. I will try using the npm package tomorrow, to see if that finds anything.

marcysutton commented 7 years ago

@boyum did you ever run your code with axe-core to find out? I agree that axe-cli should report the contrast ratio and colors in the result–I was surprised to find it was super light on reporting.

boyum commented 7 years ago

No, I never did, sorry. Will really try to remember this tomorrow, haha.

boyum commented 7 years ago

@marcysutton axe-core returns no violations, as it should.

dylanb commented 7 years ago

closing due to no issue

marcysutton commented 7 years ago

I think that means there is an issue with axe-cli–it was returning issues that axe-core wasn't.

marcysutton commented 7 years ago

@boyum can you provide us with a test case so we can debug those issues? An HTML file would be ideal so we can isolate your contrast results with axe-cli.

boyum commented 7 years ago

Unfortunately, I cannot seem to reproduce this error anymore, on the exact same page. I don't think it was, but it might very well have been a user error.

However, I might have discovered something else: Axe-cli run with Hyper (https://github.com/zeit/hyper) consequently returns 3 issues on http://orkide.preprod.acos.no, while Command Prompt and PowerShell returns only one issue. I'll file this as a seperate issue if you want me to.

Keep up the good work!