dequelabs / axe-cli

[Deprecated] A command-line interface for the aXe accessibility testing engine
Mozilla Public License 2.0
430 stars 35 forks source link

timer for waiting for page to fully load #33

Closed kensgists closed 6 years ago

kensgists commented 7 years ago

It looks like --timeout allows the user to set an automatic timeout for long pages, but is it possible to set a "wait" so that a page can complete loading of all resources before axe runs?

WilcoFiers commented 7 years ago

You are right. The timeout option lets you change how long webdriver will wait before deciding the page isn't going to load. But there is no option that lets you delay after loading. Axe-cli attempts to determine when the browser is done, which is does fairly well, but if things get pulled in after the load, there's no consistent way to determine that. We could possibly add a -load-delay option to do something like that?

kensgists commented 7 years ago

Yes, a --load-delay option would be helpful for such cases. Thanks.

AkshanshSrivastava03 commented 6 years ago

Hi @WilcoFiers, Is --load-delay option incorporated in axe-cli?

WilcoFiers commented 6 years ago

This isn't currently being worked on. We'd welcome a pull request to add this feature.

JayKid commented 6 years ago

Sorry @WilcoFiers , I forgot to add docs for it.. so I created a small (1-commit) PR for it 🙈 :

https://github.com/dequelabs/axe-cli/pull/54

WilcoFiers commented 6 years ago

Yikes! Can't believe I missed that :/ Glad you spotted it.

kensgists commented 6 years ago

Hi @WilcoFiers and @JayKid, has this landed in prod yet?

Also (perhaps another feature request) would there be a way to, in addition to an set delay, have axe-cli wait on the rendering of an element?

WilcoFiers commented 6 years ago

@kensgists We released axe-cli 3.0 yesterday :)