search

dequelabs / axe-cli

[Deprecated] A command-line interface for the aXe accessibility testing engine
Mozilla Public License 2.0
430 stars 35 forks source link

Headless chrome #36

Closed WilcoFiers closed 6 years ago

WilcoFiers commented 7 years ago

I had some difficulties figuring out why our tests stopped passing. I think it has something to do with PhantomJS, but it was very hard to debug. So instead I decided, since we should replace PhantomJS anyway, that time was better spent figuring out how to get headless Chrome working. So that's what this PR does:

This does mean that we're no longer shipping axe-cli with its own browser. As the default, it needs CHrome 59+ to be installed in a predictable location. Axe-cli installs chromedriver though.

I am working on a few other things that I want to ship in 2.0. Mainly better test coverage and the ability to run axe-core@next. I'll have those in separate PRs.

WilcoFiers commented 7 years ago

Not sure why the tests are failing now... It worked before: https://circleci.com/gh/dequelabs/axe-cli/32 I'll figure it out.

WilcoFiers commented 7 years ago

Temporary fix for the issue. I need to figure out how to install a chrome driver in Circle. I'll do that as part of my test coverage work.

marcysutton commented 7 years ago

@WilcoFiers the tests fail for me locally as well, even after running a clean npm install. Puppeteer is out now, perhaps we should look into that instead? https://github.com/GoogleChrome/puppeteer

marcysutton commented 6 years ago

This works for me now, nice work.

mohanraj-r commented 6 years ago

@WilcoFiers Curious to know why this was not merged? Are there alt plans / WIP ?