search

dequelabs / axe-core-maven-html

Tools for using axe for web accessibility testing with JUnit, Selenium, and Playwright
Mozilla Public License 2.0
81 stars 102 forks source link

Refactor: Selenium to use utilities module #252

Closed jonreding2010 closed 2 years ago

jonreding2010 commented 2 years ago

Deleted the axeargs and results files in selenium module added dependence on Utilities module imported all classes used with axeargs to use the classes in the Utilites module

jonreding2010 commented 2 years ago

I do have a question regarding the Results/Axe Results classes. They seem to be very similar if not the same, will there be a change for Playwright and Selenium to use the same Result class?

Zidious commented 2 years ago

I do have a question regarding the Results/Axe Results classes. They seem to be very similar if not the same, will there be a change for Playwright and Selenium to use the same Result class?

This was an oversight and my mistake when I created the Playwright package, it will likely be removed to consume Result in a later release

Zidious commented 2 years ago
AndrewGnagy commented 2 years ago

Should this have been accompanied by a version bump?