padmavemulapati
commented
1 year ago Validated with the Canary build - Playwright-4.7.0-SNAPSHOT
Earlier for axe-core dependency we used to add the dependency with ^, which allows minor updates -
Now we are pinning the axe-core version to strict to the updated version.
This is now holding axe-core_4.8.2 , we can see in the results when the test page is scanned:
for axe-core-maven-html-selenium package:
for axe-core-maven-html-playwright package:
Environment:
| Label | Value |
|---|---|
| Product | axe-core-maven-html |
| Version | 4.7.0-SNAPSHOT |
| OS-Details | MAC- Intel Core i7 - 11.6.8 & Windows11 |
| BrowserDetails | Chrome Version 117.0.5938.88 (Official Build) (64-bit) & Firefox 117.0 |
A user recently ran into a problem where they installed an api at v4.7 but got axe-core version v4.8 (causing some confusion on why rules weren't running that should have been). Turns out that we've been pinning to axe-core using
^which allows minor updates. This goes against our goal of version locking the apis to the major and minor version of axe-core that is used in the api.We'll fix this by using an exact match to patch pin our axe-core dependency.