dequelabs / axe-core-maven-html

Tools for using axe for web accessibility testing with JUnit, Selenium, and Playwright
Mozilla Public License 2.0
81 stars 102 forks source link

ci: update `prepare_release.sh` to take optional release level #367

Closed Zidious closed 1 year ago

Zidious commented 1 year ago

This PR allows the unnamed argument to be optional, if it's not specified it will default standard-version handling version, otherwise it will release as the specified release level.

Without specifying a release level image
With release level image

Closes: https://github.com/dequelabs/axe-core-maven-html/issues/365

Zidious commented 1 year ago

LGTM, though would like to double check on historical context of the second standard-version invocation before merging, per offline discussion

Offline discussion -

Spoke with Adam, we discussed that it was done to bump the selenium package json but did not realise that it bumps package json if ran on the root so there was no need to run it on the root and then in the sub directory