search

dequelabs / axe-core-maven-html

Tools for using axe for web accessibility testing with JUnit, Selenium, and Playwright
Mozilla Public License 2.0
81 stars 102 forks source link

Consolidate Result/AxeResults to one class/package #389

Open bdschultzAU opened 1 year ago

bdschultzAU commented 1 year ago

Is it possible to consolidate these two classes into one? I'm in a situation where my organization uses axe for selenium & playwright and we have a shared library for managing results with both.

playwright: com.deque.html.axecore.results.AxeResults selenium: com.deque.html.axecore.results.Results

I saw that AxeRunOptions was consolidated in a similar manner.

Zidious commented 1 year ago

Hey @bdschultzAU,

I think overall that's a good direction to go down. We couldn't directly change the return signature from AxeResults.class to Result.class as part of analyze() as that would be classed as a breaking change, that change would need to wait for 5.0 which is quite a while out.

Is this something that's urgent, or more of a tedious juggle between the two?

bdschultzAU commented 1 year ago

It would be a nice-to-have, allowing us to simplify the code. I used generics to allow both to work with our parent class for now. Thank you