dequelabs / axe-core-nuget

Axe Core integration for C# .NET
19 stars 6 forks source link

Pin axe-core version to exact match #114

Closed dequejenn closed 1 year ago

dequejenn commented 1 year ago

A user recently ran into a problem where they installed an api at v4.7 but got axe-core version v4.8 (causing some confusion on why rules weren't running that should have been). Turns out that we've been pinning to axe-core using ^ which allows minor updates. This goes against our goal of version locking the apis to the major and minor version of axe-core that is used in the api.

We'll fix this by using an exact match to patch pin our axe-core dependency.

padmavemulapati commented 1 year ago

Validated with the latest canary build avaible for axe-core-nuget (4.7.2-alpha.49)

image

For Axe-core-nuget we are not externally/intenally keeping package.json to specify the dependencies. But whatever the version for axe-core is updated , axe-core-nuget is holding strictly that version. (which will not allow minor updates)

Playwright Holding axe-core 4.8.2 image

Selenium holding axe-core4.8.2 image

HelpURL also getting with axe/4.8/

image

Environment:

Label Value
Product axe-core-nuget
Version 4.7.2-alpha.49
OS-Details MAC- Intel Core i7 - 11.6.8 & Windows11
BrowserDetails Chrome Version 117.0.5938.88 (Official Build) (64-bit) & Firefox 117.0