search

dequelabs / axe-core

Accessibility engine for automated Web UI testing
https://www.deque.com/axe/
Mozilla Public License 2.0
5.75k stars 746 forks source link

fix(aria-roles): correct abstract roles (types) for aria-roles #4421

Closed gaiety-deque closed 1 month ago

gaiety-deque commented 2 months ago

Too many aria roles were set to widget or otherwise were incorrect, added a comment source for where I got my information for which abstract roles were the type of other aria roles

Fix: #4371

gaiety-deque commented 2 months ago

@WilcoFiers unsure how to test this PR's changes against the comment you left in the referenced issue, I don't see a cookie notice on the horse insurance website. Any guidance is appreciated.

@straker I feel reasonably good about this change but I'm a bit unsure if it fully addresses the original issue as it seemed fairly open ended

straker commented 2 months ago

Will also need to add exception to focus-order-semantics to allow alert and alertdialog roles (add unit & integration tests to match)

gaiety-deque commented 2 months ago

Will also need to add exception to focus-order-semantics to allow alert and alertdialog roles (add unit & integration tests to match)

@straker added an exception to focus-order-semantics, renamed check and added a window test describe for both allowed role types. Refactored the test check as well, I'm all about verbose test files with repetition but 500+ lines had me scrolling all over the place losing track so I simplified down the checks to a static easier to comprehend list facd65f6 (and bfa95ae)

gaiety-deque commented 2 months ago

@WilcoFiers all feedback addressed :) let me know if there's anything else amiss