search

dequelabs / axe-core

Accessibility engine for automated Web UI testing
https://www.deque.com/axe/
Mozilla Public License 2.0
6.04k stars 784 forks source link

prototype.js breaks axe-core v4.9.0 #4428

Closed straker closed 7 months ago

straker commented 7 months ago

Websites that use prototype.js cause axe-core v4.9.0 to not be able to load. When trying to load axe-core on the page we get an error Uncaught TypeError: No color space found with id = "oklch".

In order to get v4.9.0 working we are going to revert our update to colorjs from v0.5.0. This will allow axe-core to load on the page but will cause color-contrast to error during it's run. To fix that we're going to load an Array.from polyfill right before we call colorjs code to fix the problem, then restore the prototype.js Array.from implementation right afterwards.

romankulkovsf commented 7 months ago
padmavemulapati commented 7 months ago

Validated with the latest axe-core dev branch code base, now on websites that uses prototype.js (http://script.aculo.us/), we are able to load and getting the a11y issues if any. But not getting color space with id="oklch"

https://github.com/dequelabs/axe-core/assets/47409579/3154792d-757b-4246-b6d4-f4076ba02a78

Environment:

Label Value
Product axe-core
Version 4.9.0(Dev Branch Code base
OS-Details MAC- Intel Core i7 - 11.6.8
BrowserDetails Chrome Version 124.0.6367.119 (Official Build) (64-bit)