dequelabs / axe-core

Accessibility engine for automated Web UI testing
https://www.deque.com/axe/
Mozilla Public License 2.0
5.9k stars 772 forks source link

style(lib/checks): var -> let and const codemod #4451

Closed gaiety-deque closed 4 months ago

gaiety-deque commented 4 months ago

This is a piece of a larger creative time PR so it's easier to review, the full scope can be seen here and includes eslint adjustments not seen here https://github.com/dequelabs/axe-core/pull/4444


Who else does this?

Why do this?

Gaiety's explanation: "let works the way most devs think var works. scope leaking and variable hoisting is a messy confusing idea, JS got updated for a reason" also it's 2024, this isn't too controversial anymore

romankulkovsf commented 4 months ago

Thnks