dequelabs / axe-core

Accessibility engine for automated Web UI testing
https://www.deque.com/axe/
Mozilla Public License 2.0
5.75k stars 746 forks source link

test: rename generic test titles #4453

Closed straker closed 1 month ago

straker commented 1 month ago

These tests failed while in-development of https://github.com/dequelabs/axe-core/pull/4452 and it really confused me. Based on how the title is written, I initially thought that it was making sure that .selector (etc.) for the DqElement prototype function was never called. But what it's really making sure is that the .selector (etc.) property is not called for the one node.

The reason that distinction matters is because processAggregate calls nodeSerializer which in turn calls the toJSON method of a DqElement, which calls the .selector (etc.) property. So it would be impossible to never call the DqElement properties.

romankulkovsf commented 1 month ago

Thnk