Typ defs missing for `commons.color`

dequelabs / axe-core

Accessibility engine for automated Web UI testing

https://www.deque.com/axe/

Mozilla Public License 2.0

5.95k stars 775 forks source link

Typ defs missing for `commons.color` #4604

Open vincerubinetti opened 1 week ago

vincerubinetti commented 1 week ago

Product

axe-core

Product Version

4.10.0

Latest Version

[X] I have tested the issue with the latest version of the product

Issue Description

https://github.com/search?q=repo%3Adequelabs%2Faxe-core%20getBackgroundColor&type=code

https://github.com/search?q=repo%3Adequelabs%2Faxe-core+commons&type=code

I've run into other incorrect/missing typings too but unfortunately can't remember them. I'd strongly recommend a repo-wide audit for types.

WilcoFiers commented 1 week ago

Axe core commons are not considered part of the public API of axe-core. Some of them are typed because people have found typing them useful, but most of them are not. Feel free to open a pull request if you wish to have types for these.