search

dequelabs / axe-firefox-devtools

Integration of axe-core into the Firefox developer tools
17 stars 6 forks source link

feat: configure application branding #49

Closed marcysutton closed 7 years ago

marcysutton commented 7 years ago

@dylanb should we configure aXe application branding in an attach handler or is this sufficient? I tried emitting and listening for an attach event from panel.js but nothing ever occurred. Putting axe.configure outside of the message handler threw a ReferenceError, unlike axe-chrome.

Closes https://dequesrc.atlassian.net/browse/WWD-498

marcysutton commented 7 years ago

Done. You think it's okay in the analyze handler?

dylanb commented 7 years ago

yep, you could save a teeny amount of time for subsequent analyses by putting it into the startup code but that is almost over-optimization because it is very likely that subsequent analyses will happen after page (re)loads

marcysutton commented 7 years ago

Ok, considering we have new extensions coming I'll leave it as-is.