dequelabs / axe-webdriverjs

Provides a chainable axe API for Selenium's WebDriverJS and automatically injects into all frames.
Mozilla Public License 2.0
130 stars 46 forks source link

feat: Add `logIframeErrors` option to not print iframe error to console #117

Closed straker closed 5 years ago

straker commented 5 years ago

This uses the same option name as axe-cli with the idea being that it can just pass the option directly into this. The default is true so behavior doesn't change from before, and only passing stdout: false will cause it to throw the error.

Closes: #41

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

straker commented 5 years ago

@stephenmathieson I can see what you mean. The option was suppose to mimic the axe-cli --stdout flag, which is a boolean. I was going for consistency in API names since axe-cli uses axe-webdriver. What do you think of printToStdout or maybe verbose?

stephenmathieson commented 5 years ago

Maybe something like logIframeErrors: true | false? This way it clearly states its purpose.

padmavemulapati commented 5 years ago

Dev Task.

stephenmathieson commented 5 years ago

@padmavemulapati there is something "QA-able" here. One could verify the behavior with/without the logIframeErrors option provided.