fix: properly switch to sibling frames - Githubissues

dequelabs / axe-webdriverjs

Provides a chainable axe API for Selenium's WebDriverJS and automatically injects into all frames.

Mozilla Public License 2.0

130 stars 46 forks source link

fix: properly switch to sibling frames #140

Closed AdnoC closed 4 years ago

AdnoC commented 4 years ago

Frame context code was not properly switching frames due to context being switched. You have to go back to the parent frame.

If we only needed to support selenium-webdriver@4.0.0 this would be a 1 line change adding a call to driver.switchTo().parentFrame().

Closes issue: https://github.com/dequelabs/attest-node-suite/issues/246

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

[x] Follows the commit message policy, appropriate for next version
[x] Code is reviewed for security