sandbox busting only happens in top-level context

dequelabs / axe-webdriverjs

Provides a chainable axe API for Selenium's WebDriverJS and automatically injects into all frames.

Mozilla Public License 2.0

130 stars 46 forks source link

sandbox busting only happens in top-level context #141

Closed WilcoFiers closed 4 years ago

WilcoFiers commented 4 years ago

This line is only executed in the top level browser context. It should execute inside every frame:

https://github.com/dequelabs/axe-webdriverjs/blob/cfdaff27bcc025fe2eacd454db188d3e22ed38f5/lib/axe-injector.js#L132

padmavemulapati commented 4 years ago

DevTask

AutoSponge commented 4 years ago

@padmavemulapati This is testable but you may need a new fixture. See the test in this PR. You'll need an iframe (or sandboxed iframe) with a sandboxed iframe inside. Previous version of the code only worked on the first sandboxed iframe and not nested ones.

padmavemulapati commented 4 years ago

verified with sandbox nested iframe test file, it is able to check inner(nested) iframes and given one voilation regarading lang attribute for the inner most html file. So working as expected,