dequelabs / cauldron

https://cauldron.dequelabs.com/
Mozilla Public License 2.0
91 stars 21 forks source link

Font weight epic #855

Open schne324 opened 1 year ago

schne324 commented 1 year ago

Tasks

In reviewing some UI recently with @bobbyomari, he noticed some issues with our font-weight

bobbyomari commented 1 year ago

For clarity, the font-weights are as followed:

Best practices is to use the numerical value and not the words 😄

scurker commented 1 year ago

drop support for var(--font-weight-thin) as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var)

It is used in one spot: https://github.com/dequelabs/cauldron/blob/f7af2061c4314f69641af80c9f5bfffee8399f74/packages/styles/forms.css#L224

Am I assuming correctly that we're updating the font weight here with this proposed change?

scurker commented 1 year ago

I additionally found other usages of font-weight-light as well.

scurker commented 1 year ago

We can update the usages of this, but should not remove the variables until we decide we want to release a breaking change.