Open schne324 opened 1 year ago
For clarity, the font-weights are as followed:
Best practices is to use the numerical value and not the words 😄
drop support for var(--font-weight-thin) as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var)
It is used in one spot: https://github.com/dequelabs/cauldron/blob/f7af2061c4314f69641af80c9f5bfffee8399f74/packages/styles/forms.css#L224
Am I assuming correctly that we're updating the font weight here with this proposed change?
I additionally found other usages of font-weight-light
as well.
We can update the usages of this, but should not remove the variables until we decide we want to release a breaking change.
Tasks
In reviewing some UI recently with @bobbyomari, he noticed some issues with our font-weight
var(--font-weight-thin)
as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var)var(--font-weight-light)
as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var)var(--font-weight-medium)