Closed thuey closed 1 year ago
Do we have a method for handling breaking changes?
Do we have a method for handling breaking changes?
@Bracciata See: https://github.com/dequelabs/cauldron/blob/develop/CONTRIBUTING.md#breaking-changes
You will need to include BREAKING CHANGE: ...
In the commit description when merging the PR. See also: https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-description-and-breaking-change-footer
Currently, the Pagination
statusLabel
prop acceptsReactNode
: https://github.com/dequelabs/cauldron/blob/655da6e04d8fd20a817a8325c5c2f2ce7aa93449/packages/react/src/components/Pagination/Pagination.tsx#L12This is more permissive than it should be. It's important that the label contain valid content and not
null | undefined | boolean
. We should update thelabel
prop type to beContentNode
: https://github.com/dequelabs/cauldron/blob/655da6e04d8fd20a817a8325c5c2f2ce7aa93449/packages/react/src/types.ts#L9-L18Note: This would be a breaking change