dequelabs / react-axe

[DEPRECATED] Accessibility auditing for React.js applications

Other

1.16k stars 45 forks source link

feat: Support Axe-core context param #127

Closed J-Kallunki closed 4 years ago

J-Kallunki commented 4 years ago

Add Axe-core context to reactAxe-parameters.

Closes issue:

41

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

[x] Follows the commit message policy, appropriate for next version
[x] Code is reviewed for security

claassistantio commented 4 years ago

All committers have signed the CLA.

J-Kallunki commented 4 years ago

@WilcoFiers So to get npm run test pass needs to cd example && npm install styled-components. Do you know anything about that?

J-Kallunki commented 4 years ago

So I tested it to be working by changing example/src/example.js:21 to axe(React, ReactDOM, 1000, axeConf, {include: [['header']]});

Might need some help to get cypress test created for the context-parameter.

jeeyyy commented 4 years ago

@J-Kallunki the CI failure is fixed on the base branch. Could you please update your branch.

WilcoFiers commented 4 years ago

Thank you for your contribution @J-Kallunki!

neomi2428 commented 4 years ago

@WilcoFiers I am looking for this cool feature. Would you let me know when this change would be released? I just want to know rough release plan. Thanks for building this awesome project!

straker commented 4 years ago

@neomi2428 We've just created a release for it, should be merged in a few days. https://github.com/dequelabs/react-axe/pull/130

neomi2428 commented 4 years ago

@straker Sweet! I can't wait. 👍

neomi2428 commented 4 years ago

@straker I am wondering if you have plan to support a typescript version of react-axe. Do you have plan for that?

straker commented 4 years ago

@neomi2428 we currently don't have any plans for typescript, but I'll certainly look into it. I imagine it wouldn't be too hard to support for this repo.

neomi2428 commented 4 years ago

@straker I found that someone did it for react-axe 3.1. Just in case you want to look into it, I share below links.

Thanks!

straker commented 4 years ago

Awesome, it's a bit out of date though. But it was helpful for doing it myself.

straker commented 4 years ago

@neomi2428 just finished a merge #137 that converted the library to typescript

neomi2428 commented 4 years ago

That is awesome! Thanks a lot. 👍