search

dequelabs / react-axe

[DEPRECATED] Accessibility auditing for React.js applications
Other
1.16k stars 45 forks source link

TypeScript types are wrong #170

Closed danielnixon closed 4 years ago

danielnixon commented 4 years ago

This no longer compiles.

axe(React, ReactDOM, 1000);
Expected 5 arguments, but got 3.ts(2554)
index.d.ts(12, 95): An argument for 'conf' was not provided.

The fourth and fifth arguments should be optional.

m4thieulavoie commented 4 years ago

Having the same issue, I just opened a PR for this https://github.com/dequelabs/react-axe/pull/171 , hopefully it can ship quickly! 👍

m4thieulavoie commented 4 years ago

@straker think we can cut a release for this?

straker commented 4 years ago

Yep. Will hopefully get out a release today.

straker commented 4 years ago

Alright. 3.5.3 released and should fix the problem. Thank you for your help and patience.