fix: made conf and context optional again

dequelabs / react-axe

[DEPRECATED] Accessibility auditing for React.js applications

Other

1.16k stars 45 forks source link

fix: made conf and context optional again #171

Closed m4thieulavoie closed 4 years ago

m4thieulavoie commented 4 years ago

Just realized that the two last optional parameters are not optional anymore since the Typescript upgrade

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

[x] Follows the commit message policy, appropriate for next version
[x] Code is reviewed for security

m4thieulavoie commented 4 years ago

Thanks for the pr. Since we're here, I believe the timeout parameter should also be optional. Would you mind updating that as well? If not then I can do it after this is merged.

Looking at IdleRequestOptions, I am not 100% certain timeout can be optional.

interface IdleRequestOptions {
    timeout: number;
}

Thoughts?

straker commented 4 years ago

Hu. So the options parameter is optional but the timeout is required in it? Guess it can't be optional. Thanks for looking into it.