search

dequelabs / react-axe

[DEPRECATED] Accessibility auditing for React.js applications
Other
1.16k stars 45 forks source link

Ignore axe/3.5/region by default #182

Closed AdrienLemaire closed 4 years ago

AdrienLemaire commented 4 years ago

After setting up react-axe, I got this error: All page content must be contained by landmarks.

Given that we use react, which must have a root div element, shouldn't this error be ignored by default ? This SO answer gives more info about why it's safe to ignore it.

straker commented 4 years ago

Interesting. I'm not seeing that problem using the example in react-axe (adding a <main> element around the <ServiceChooser> removes the error, as is expected). Axe-core should only flag actual text content with that error and not elements. You should be able to wrap the landmarks with any amount of divs.

image

straker commented 4 years ago

We have moved this package to be under our axe-core-npm monorepo for easier management. As a result, this repository will be deprecated in the coming weeks.

I have transferred the issue so we can still keep track of it.