search

dequelabs / react-axe

[DEPRECATED] Accessibility auditing for React.js applications
Other
1.16k stars 45 forks source link

axe issues thrown when there are no issues #183

Closed AdrienLemaire closed 4 years ago

AdrienLemaire commented 4 years ago

As you can see, the issues are toggled but no link to the code is given below them.

I've also verified that I do have only 1 <main> element and only one <h1> within it

versions used:

{
    "react-axe": "^3.5.3",
    "react": "0.0.0-experimental-94c0244ba",
    "react-dom": "0.0.0-experimental-94c0244ba"
}
straker commented 4 years ago

Out of curiosity, are these issues being thrown as the page is loaded (this and the other issue you posted? I'm wondering if the DOM is not yet populated with react DOM when axe throws the errors

AdrienLemaire commented 4 years ago

@straker you might be right. Axe errors are thrown very quickly, and adding a slow debouncing eg 5000 doesn't seem to have any effect. Wondering if it's a react concurrent only issue

straker commented 4 years ago

Ya, debounce wouldn't help for initial loading before the page is ready. I know #134 also had that problem and it's something we're trying to look into.

straker commented 4 years ago

We have moved this package to be under our axe-core-npm monorepo for easier management. As a result, this repository will be deprecated in the coming weeks.

I have transferred the issue so we can still keep track of it.