Closed dequejenn closed 1 year ago
Pulled the latest watcher-example repo for playwright, but in manual mode wrapPlaywright
is missing in below 2 places
1)at the top of test file
2)Within the Before hook of test file
https://github.com/dequelabs/watcher-examples/assets/45222788/245d4d95-127a-4a0c-a22c-8f23cb6c1181
We do not need to have wrapPlaywright
for manual mode as we call controller.analyze()
whenever we want to analyze. I guess this is more of a consistency question. @dequejenn shall we remove them from the this from the docs on the start up?
We need the code to switch between auto and manual with a switch of the autoAnalyze
flag in the config. Otherwise that flag is useless. So whatever has to happen to make sure if you set autoAnalyze: true
it runs in automatic mode successfully and autoAnalyze: false
it runs in manual mode successfully with no other changes.
Removing manual mode from this scope so this ticket can be QA'd (manual mode on hold). QA - please only QA the auto basic example here. Thanks!
Tested only for auto basic example, working as expected.
https://github.com/dequelabs/watcher-examples/assets/47409579/0d6b6420-a9d3-452f-aa15-593f17008f34
Label | Value |
---|---|
Server URL | https://axe.dequelabs.com/ |
Server version | 4.82.0 |
@axe-core/watcher version | 2.0.0-next.099d5645 |
Playwright | 1.33.0 |
The Playwright example needs to be changed to work with the newest wrapped Playwright code and should include an example for automatic mode and one for manual mode, as well as have all dependancies updated (i.e. use Cypress 12)