search

deraadt / Moodle-block_progress

A time management tool for you and your students
http://moodle.org/plugins/view.php?plugin=block_progress
23 stars 54 forks source link

CSS Styling issue #9

Closed jinhofer closed 6 years ago

jinhofer commented 9 years ago

Michael,

I looked at your recent CSS changes that originated due the Moodle ticket about CSS rules that were too general, and I believe that you may have made your rules too specific. In the case where the selector is something like ".progressoverviewmenus", ".overviewButton", or ".block_progress", those rules target classes that you created solely for your HTML elements and don't need the #page-blocks-progress-overview tag incorporated with them. In the case of ".overviewButton", this class appears on the course page, which will not have the id page-blocks-progress-overview. I think that the only changes that need to be made are:

-- .buttons { ++ #page-blocks-progress-overview .buttons { margin-top: 20px; text-align: center; }

and

-- .buttons label { ++ #page-blocks-progress-overview .buttons label { display: inline; margin: 0 5px 0 10px; }

deraadt commented 9 years ago

Hi.

Thanks for pointing out the problem in the first place and thanks for checking my solution.

You are correct. I did go too far with my changes. While I want to be as specific as I can with my selectors, I incorrectly applied the Overview page selector to a few things that didn't need them, including some selectors for the block instance configuration page.

I've checked a bit more thoroughly now and put up another version.

Photo of Michael de Raadt
Michael de Raadt /BSci(Hons), PhD/ Research Director, Moodle HQ http://moodle.com/hq/ Availability: Calendar http://dl.dropbox.com/u/11561272/calendar.html Email: michaeld@moodle.com mailto:michaeld@moodle.com Twitter: @salvetore https://twitter.com/salvetore @moodleresearch https://twitter.com/moodleresearch LinkedIn: linkedin.com/in/michaelderaadt http://linkedin.com/in/michaelderaadt

Moodle logo http://moodle.org

On 19/12/2014 5:46 AM, jinhofer wrote:

Michael,

I looked at your recent CSS changes that originated due the Moodle ticket about CSS rules that were too general, and I believe that you may have made your rules too specific. In the case where the selector is something like ".progressoverviewmenus", ".overviewButton", or ".block_progress", those rules target classes that you created solely for your HTML elements and don't need the

page-blocks-progress-overview tag incorporated with them. In the case

of ".overviewButton", this class appears on the course page, which will not have the id page-blocks-progress-overview. I think that the only changes that need to be made are:

-- .buttons { ++ #page-blocks-progress-overview .buttons { margin-top: 20px; text-align: center; }

and

-- .buttons label { ++ #page-blocks-progress-overview .buttons label { display: inline; margin: 0 5px 0 10px; }

— Reply to this email directly or view it on GitHub https://github.com/deraadt/Moodle-block_progress/issues/9.