derail-valley-modding / custom-car-loader

A Derail Valley mod that allows the addition of new cars and locomotive types to the game.
https://nexusmods.com/derailvalley/mods/324
MIT License
14 stars 6 forks source link

Collider missing warnings #157

Closed WhistleWiz closed 11 months ago

WhistleWiz commented 11 months ago

First commit changes cargo validator to only have a warning on missing bounding collider. Second commit further forgives the validation by checking the children for colliders.

WhistleWiz commented 11 months ago

One more thing, it could be a good idea to change from BoxCollider to just Collider? Boxes are the best but there might be cases of capsules or spheres only.

WhistleWiz commented 11 months ago

And now, should this be also changed on the livery collider check instead of just the cargo? The "collider will be auto-generated" leaves me unsure.

katycat5e commented 11 months ago

The main vehicle colliders are a bit stricter I think, if we're not running into issues there I think it might be best to leave as-is for now.

WhistleWiz commented 11 months ago

It's a bit odd, I am copying the exact setup of vanilla cars, and they often don't have a component on the [collision] object. image image

katycat5e commented 11 months ago

Maybe this was something that was changed between OVH and sim